Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle] Exclude unreadable files when executing About command #40178

Merged
merged 1 commit into from
Mar 16, 2021
Merged

[FrameworkBundle] Exclude unreadable files when executing About command #40178

merged 1 commit into from
Mar 16, 2021

Conversation

michaljusiega
Copy link
Contributor

@michaljusiega michaljusiega commented Feb 13, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39916
License MIT
Doc PR ~

Fix as explained in: #39916.

Tests failed looks like not releated to my changes.

@carsonbot carsonbot added this to the 4.4 milestone Feb 13, 2021
ro0NL
ro0NL approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

michaljusiega
michaljusiega commented Feb 16, 2021
View reviewed changes
Copy link
Contributor Author

@michaljusiega michaljusiega left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@michaljusiega
Copy link
Contributor Author

@fabpot Can We finish this PR ?

@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Exclude unreadable file during executing About command. [FrameworkBundle] Exclude unreadable file during executing About command Mar 16, 2021
@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Exclude unreadable file during executing About command [FrameworkBundle] Exclude unreadable files during executing About command Mar 16, 2021
@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Exclude unreadable files during executing About command [FrameworkBundle] Exclude unreadable files when executing About command Mar 16, 2021
@nicolas-grekas
Copy link
Member

Thank you @michaljusiega.

@nicolas-grekas nicolas-grekas merged commit e21004d into symfony:4.4 Mar 16, 2021
This was referenced Mar 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@fabpot fabpot fabpot requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@ro0NL ro0NL ro0NL approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@michaljusiega @nicolas-grekas @fabpot @javiereguiluz @ro0NL @carsonbot