[TwigBundle] Deprecate option "autoescape", use "autoescape_service[_method]" instead #46052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is a foot-gun, even the tests are wrong since
true
doesn't mean anything for it.Also because eg disabling auto-escaping breaks forms / emails, which expect an
html
escaping strategy.I therefore propose to deprecate option
autoescape
and to keepautoescape_service
+autoescape_service_method
, which are more capable, and will require ppl to think twice before returningfalse
.For ppl that need a custom escaping strategy, you'll likely want to use/take inspiration from
FileExtensionEscapingStrategy::guess()
in your implementation.