Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DependencyInjection] Spaces in system temp folder path cause deprecation errors in php 8 #46800

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[DependencyInjection] Spaces in system temp folder path cause deprecation errors in php 8 #46800

merged 1 commit into from
Jun 29, 2022

Conversation

demeritcowboy
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46799
License MIT
Doc PR

See #46799

@carsonbot carsonbot added this to the 4.4 milestone Jun 29, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@demeritcowboy demeritcowboy mentioned this pull request Jun 29, 2022
Closed
@nicolas-grekas nicolas-grekas changed the title [dependency-injection] Spaces in system temp folder path cause deprecation errors in php 8 [DependencyInjection] Spaces in system temp folder path cause deprecation errors in php 8 Jun 29, 2022
nicolas-grekas
nicolas-grekas approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I verified locally)

@carsonbot carsonbot changed the title [DependencyInjection] Spaces in system temp folder path cause deprecation errors in php 8 Spaces in system temp folder path cause deprecation errors in php 8 Jun 29, 2022
@nicolas-grekas
Copy link
Member

Thank you @demeritcowboy.

@nicolas-grekas nicolas-grekas merged commit 2c26d24 into symfony:4.4 Jun 29, 2022
@demeritcowboy demeritcowboy deleted the issue46799-4.4 branch June 29, 2022 12:32
@demeritcowboy
Copy link
Contributor Author

Thanks!

@carsonbot carsonbot changed the title Spaces in system temp folder path cause deprecation errors in php 8 [DependencyInjection] Spaces in system temp folder path cause deprecation errors in php 8 Jul 4, 2022
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@demeritcowboy @carsonbot @nicolas-grekas @xabbuh