[Console] Fix error output on windows cli

[maxbeckers]

Q	A
Branch?	6.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #47862
License	MIT
Doc PR

In the issue #47862 a console output bug was detected.

Before the fix on a windows cli:

After the fix:

The problem have been the linebreaks in the message.

[wouterj]

I can confirm this does not change the output on Linux.

Should be merged in 4.4 imho (we can switch branches during the merge)

[chalasr]

Note that the issue might be SymfonyStyle::block() not properly handling inputs with a leading line break, but I'm fine merging this and revisit if the problem comes out again in the future.

[maxbeckers]

@chalasr it's a bug with linebreaks at all on windows cli, not just leading. see the screenshot with a linebreak in the middle.

The code behind the screenshot:
$style->block(sprintf("Command \"%s\" is\nnot defined.", $name), null, 'error', " ", true);

[chalasr]

Thank you @maxbeckers.

[maxbeckers]

@chalasr, just a info because i figured out now ... using the constand PHP_EOL what is on windows \r\n will keep the block as expected:

So in future we should use the constant for linebreaks.

[stof]

to me, we should rather make SymfonyStyle compatible with both PHP_EOL and \n in the input string.