-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mailer] Fix BC breaking event name change #47992
Conversation
d39b078
to
e57c3a5
Compare
e57c3a5
to
7fe7a05
Compare
7fe7a05
to
e1eb717
Compare
@nesl247 Yes it does, thanks for noticing and testing dev branches. |
src/Symfony/Component/Mailer/EventListener/MessageLoggerListener.php
Outdated
Show resolved
Hide resolved
e1eb717
to
8845ccb
Compare
8845ccb
to
be71c4d
Compare
aec4b00
to
0b3b3df
Compare
0b3b3df
to
cb64938
Compare
Thank you @chalasr. |
Sorry to hijack this thread, but wanted to confirm that after this merge, the profiler is still confused and showing 2 emails sent in the left menu and 1 queued and 1 sent. Is this on purpose or something else that needs fixing? My code is only sending one email.
|
I'll have a look today, thanks for telling us. |
@PhilETaylor I can't reproduce on a basic setup sorry, I get only one queued email reported in the profiler panel. Please make sure it's not an issue in your code and if it's not, consider opening an issue with a minimal application that allows reproducing the issue. Thanks |
yes, 30 seconds ago I tested my symfony demo site and I could also not reproduce it - dang it! Sorry for wasting your time, I'll dig deeper. The edit: Should also say, 6.1 gives only 1 email in the profiler, not 2 - dang it :) :) |
ok I fired up the laptop which has never seen 6.2 and now I can replicate my issue in my app only in |
This PR was merged into the 6.2 branch. Discussion ---------- [Mailer] remove `QueuingMessageEvent` Related to [47992 in code](symfony/symfony#47992) - QueuingMessageEvent class has been removed due to BC break Related to symfony#17111 in doc Remove explanations about this specific event but keep new methods added in previously existing MessageEvent Commits ------- 9bc26d1 remove QueuingMessageEvent from documentation
While I get the motivation for introducing this
QueuingMessageEvent
child event in #47191, it's a BC break that is difficult to circumvent due to the fact it's an event (the parent may still be used as it's not deprecated).So I propose to revert its addition and just add the needed stamp-related methods to the original event instead.