[SecurityBundle] Deprecate enabling bundle and not configuring it #48043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @TimoBakx has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
fabpot
reviewed
Nov 1, 2022
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Outdated
Show resolved
Hide resolved
alamirault
requested review from
fabpot
and removed request for
wouterj and
chalasr
derrabus
approved these changes
Nov 1, 2022
chalasr
reviewed
Nov 5, 2022
src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/AliasedEvents/config.yml
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Nov 5, 2022
fabpot
approved these changes
Nov 26, 2022
fabpot
force-pushed
the
feature/47593-no-security-configuration-trigger-deprecation
branch
from
a08dcc6
to
ff76d26
Compare
|
Thank you @alamirault. |
alamirault
deleted the
feature/47593-no-security-configuration-trigger-deprecation
branch
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2023
…figuring it is not allowed (alexandre-daubois) This PR was merged into the 7.0 branch. Discussion ---------- [SecurityBundle] Enabling `SecurityBundle` and not configuring it is not allowed | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Removes the code deprecated in #48043 Commits ------- 2388239 [SecurityBundle] Enabling `SecurityBundle` and not configuring it is not allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve DX, add Trigger deprecation when
SecurityBundleis enable without configuration.