Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier][TurboSMS] Fix get sender name #50352

Conversation

ZhukV
Copy link
Contributor

@ZhukV ZhukV commented May 17, 2023

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Fix get sender name in Turbo Sms Transport.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark OskarStark changed the title Fix get sender name in turbosms notifier [Notifier][TurboSMS] Fix get sender name May 17, 2023
@nicolas-grekas
Copy link
Member

Thank you @ZhukV.

@nicolas-grekas nicolas-grekas merged commit bf262b9 into symfony:6.2 May 18, 2023
7 checks passed
This was referenced May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants