Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Bump to PHP 8.2 minimum #50404

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

馃殌

.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
.github/workflows/unit-tests.yml Show resolved Hide resolved
src/Symfony/Bridge/PhpUnit/Tests/EnumExistsMockTest.php Outdated Show resolved Hide resolved
src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php Outdated Show resolved Hide resolved
src/Symfony/Bridge/PhpUnit/composer.json Outdated Show resolved Hide resolved
src/Symfony/Contracts/Cache/composer.json Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member Author

Thanks for the review @stof. Comments addressed.

@stof
Copy link
Member

stof commented May 23, 2023

@nicolas-grekas for my comment about the PHP version bump in contracts, it actually applies to all of them, not just the cache contracts

@nicolas-grekas
Copy link
Member Author

@stof oops, fixed!

@nicolas-grekas
Copy link
Member Author

  • composer/composer[2.4.0, ..., 2.6.x-dev] require symfony/console ^5.4.11 || ^6.0.11 -> found symfony/console[v5.4.11, ..., 5.4.x-dev, v6.0.11, ..., 6.3.x-dev] but it conflicts with your root composer.json require (^6.4|^7.0). /cc @Seldaek
  • async-aws/core[1.10.0, ..., 1.18.1] require symfony/http-client ^4.4.16 || ^5.1.7,!=5.2.0 || ^6.0 -> found symfony/http-client[v4.4.16, ..., 4.4.x-dev, v5.1.7, ..., 5.4.x-dev, v6.0.0, ..., 6.3.x-dev] but it conflicts with your root composer.json require (^6.4|^7.0). /cc @jderusse
  • doctrine/orm[2.12.0, ..., 2.13.x-dev] require symfony/console ^3.0 || ^4.0 || ^5.0 || ^6.0 -> satisfiable by symfony/console[v5.4.0, ..., 5.4.x-dev, v6.0.0, ..., 6.3.x-dev]. /cc @derrabus

It's time to allow Symfony 7 again :)

@nicolas-grekas nicolas-grekas merged commit cfb451f into symfony:7.0 May 23, 2023
6 of 9 checks passed
@nicolas-grekas nicolas-grekas deleted the php82 branch May 23, 2023 18:38
nicolas-grekas added a commit that referenced this pull request May 30, 2023
This PR was merged into the 7.0 branch.

Discussion
----------

[7.0] Remove hacks that made the CI green

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follows #50404

The Windows build is blocked by ext-redis and ext-apcu not being available as DLL for PHP 8.2. /cc `@weltling` 馃檹

It's time to allow Symfony 7 again :)

- [x] composer/composer#11474
- [x] async-aws/aws#1409
- [x] doctrine/orm#10724
- [x] [FriendsOfPHP/proxy-manager-lts](FriendsOfPHP/proxy-manager-lts@d93bd79)
- [x] symfony/security-acl#111
- [x] tijsverkoyen/CssToInlineStyles#243

We also need a sigchild-enabled PHP, which `@derrabus` knows how to build :)

Commits
-------

6dd126a [7.0] Remove hacks that made the CI green
@fabpot fabpot mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants