[Notifier] Fix Esendex messages serialization #50893
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3". Cheers! Carsonbot |
|
Thank you. Can we add a test that covers your change? |
|
Sure I will try :) |
|
I added a test but feel free to modify it to comply to your level of requirement. |
|
|
||
| $body = json_decode($requestOptions['body'] ?? ''); | ||
|
|
||
| $this->assertIsArray($body->messages); |
There was a problem hiding this comment.
Let's test the content of the array.
There was a problem hiding this comment.
Done ✅ Does it suit ?
|
Thank you @raphael-geffroy. |
It seems that the "messages" is missing a dimension since 6.3 and its serialized as an object instead of an array of objects.