[Routing] Fix routing collection defaults when adding a new route to a collection #51704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram123
changed the title
|
Test failures are (hopefully) unrelated; or did I do something wrong? |
fancyweb
approved these changes
Sep 20, 2023
src/Symfony/Component/Routing/Loader/Configurator/CollectionConfigurator.php
Outdated
Show resolved
Hide resolved
fancyweb
reviewed
Sep 20, 2023
src/Symfony/Component/Routing/Loader/Configurator/CollectionConfigurator.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
routing_collection_defaults
branch
from
787b4c9
to
bfdd16e
Compare
|
Good catch, thanks @bram123. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our current Symfony project we use PHP routing files, and use routing collections that are setup before adding routes.
Before upgrading to Symfony 6.3 this meant we could add an attribute to the collection, add X routes and they would all have this routing attribute (be it stateless / methods / defaults). After upgrading to S6.3 this no longer works.
PR #49517 removed the createRoute method from the CollectionConfigurator, because it was thought to be unused, but this method was used when adding a new Route to a RouteCollection. Without the method, the createRoute method of the LocalizedRouteTrait was used.
This means that when setting up a route collection before adding routes, the new routes no longer get the collection settings.
Added a new unittest to prevent this from happening again. For now only added to the PhpFileLoaderTest, I don't know if this is also possible for XML/YML routing config to also add a test in those LoaderTests.