Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] [Mailjet] Disable tls for mailjet as it should use STARTTLS #53061

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

RFreij
Copy link
Contributor

@RFreij RFreij commented Dec 13, 2023

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

#52560 updates the default mailjet port and references the same change for mailgun.

Similar to #51042 and with the same error message, the mailjet connection doesn't work now.

The PR above already has a reference, but for completion sake: Ref #34846 (comment) for more explanation

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Thank you @RFreij.

@nicolas-grekas nicolas-grekas merged commit dfa5e5d into symfony:6.4 Dec 19, 2023
6 of 9 checks passed
@RFreij RFreij deleted the fix/mailjet-smtp branch December 27, 2023 11:32
This was referenced Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants