Skip to content

Conversation

thaberkern
Copy link

Added a secure parameter to UrlGenerator to generate HTTPS-Urls even if the current page doesn't use HTTPS.

Context-Is_Secure: true, $secure-Parameter: null => URL: https
Context-Is_Secure: false, $secure-Parameter: null => URL: http
Context-Is_Secure: true, $secure-Parameter: true => URL: https
Context-Is_Secure: true, $secure-Parameter: false => URL: http
Context-Is_Secure: false, $secure-Parameter: true => URL: https
Context-Is_Secure: false, $secure-Parameter: false => URL: http

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should prefer the ternary syntax in case of such assignments

@thaberkern
Copy link
Author

Any other comments on this? Any chance this will be merged?

@Seldaek
Copy link
Member

Seldaek commented Apr 18, 2011

I like the approach of http://trac.symfony-project.org/ticket/9686 better, because you define which routes should be served how. This could even be enforced by specifying the _scheme in the requirements maybe.

@fabpot
Copy link
Member

fabpot commented Apr 20, 2011

I have implemented something more like what @Seldaek describes in the ticket. Here is the doc for it: symfony/symfony-docs@068de1f

@fabpot fabpot closed this Apr 20, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants