[process] expose the process status. #5455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -678,6 +678,26 @@ public function setEnhanceWindowsCompatibility($enhance) | |||
| $this->enhanceWindowsCompatibility = (Boolean) $enhance; | |||
| } | |||
|
|
|||
| public function getStatus() | |||
| { | |||
| return $this->status; | |||
There was a problem hiding this comment.
are you sure you don't have to do a $this->updateStatus(); here ?
There was a problem hiding this comment.
It makes sense to add them to both getStatus() and isTerminated(), but isStarted() should be fine since run() and start() will set status and check is only against != STATUS_READY.
|
👍 |
|
This PR is missing the patch header in the description https://github.com/symfony/symfony-docs/blob/master/contributing/code/patches.rst#make-a-pull-request |
| @@ -678,6 +678,30 @@ public function setEnhanceWindowsCompatibility($enhance) | |||
| $this->enhanceWindowsCompatibility = (Boolean) $enhance; | |||
| } | |||
|
|
|||
| public function getStatus() | |||
|
@boombatower can you update the PR according to my comments and add some tests ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue #5453.