[TypeInfo] rework isA to handle class names and improve isNullable #54669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbeil
reviewed
Apr 29, 2024
xabbuh
added
the
❄️ Feature Freeze
mtarld
force-pushed
the
fix/test-class-name
branch
from
b7afcd8 to
9e9ab7b
Compare
mtarld
force-pushed
the
fix/test-class-name
branch
from
9e9ab7b to
5624ee0
Compare
fabpot
approved these changes
May 2, 2024
|
Thank you @mtarld. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54659 introduces a better design that allows us to easily handle class names in
isAand to simplifyisNullable