Add missing UPGRADE notes for 7.1 #57242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
May 30, 2024
wouterj
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | - |
| License | MIT |
wouterj
force-pushed
the
proofread-upgrade-71
branch
from
b3795c4 to
935a84b
Compare
stof
reviewed
May 30, 2024
| @@ -69,6 +120,7 @@ Form | |||
| FrameworkBundle | |||
| --------------- | |||
|
|
|||
| * [BC BREAK] Enabling `framework.rate_limiter` requires `symfony/rate-limiter` 7.1 or higher | |||
There was a problem hiding this comment.
Does FrameworkBundle 7.1 conflict with rate-limiter < 7.1 ? If yes, there is no BC break as composer deals with ensuring compatible versions.
There was a problem hiding this comment.
No, it doesn't. It's only part of the require-dev of framework bundle.
nicolas-grekas
approved these changes
May 30, 2024
fabpot
approved these changes
May 30, 2024
|
Thank you @wouterj. |
chalasr
reviewed
May 31, 2024
| DoctrineBridge | ||
| -------------- | ||
|
|
||
| * Deprecated `DoctrineExtractor::getTypes()`, use `DoctrineExtractor::getType()` instead | ||
| * Deprecate `DoctrineExtractor::getTypes()`, use `DoctrineExtractor::getType()` instead |
There was a problem hiding this comment.
This one should be removed actually eb319a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.