[Lock][Process] Replace strtok calls
#57550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
strtok-ban
branch
from
4c36edf to
1c998f9
Compare
nicolas-grekas
approved these changes
Jun 27, 2024
derrabus
approved these changes
Jun 27, 2024
|
👍 But let's wait on the vote. I don't think we want patch releases for this if the method is not deprecated. |
|
@alexandre-daubois can you please rebase for 7.2? This can be easily back-ported if the deprecation happens. |
alexandre-daubois
force-pushed
the
strtok-ban
branch
from
1c998f9 to
feed6dc
Compare
alexandre-daubois
requested review from
lyrixx,
yceruto,
chalasr,
dunglas and
xabbuh
as code owners
src/Symfony/Component/Lock/Store/DoctrineDbalPostgreSqlStore.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
strtok-ban
branch
from
feed6dc to
c76ba0d
Compare
|
Thank you @alexandre-daubois. |
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Jul 1, 2024
This PR was merged into the 4.x branch. Discussion ---------- Remove any usage of the strtok() function Similar to what Symfony is doing in symfony/symfony#57550 Commits ------- ebdae7b Remove any usage of the strtok() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I targeted 5.4, I think this is a good thing in order to be future-proof and help potential fixes upmerges, strtok being deprecated or not. Rebasing on 7.2 is not a big deal though if needed, as I only found 1 more occurrence on the latest branch.