relax mock class name matching #58391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
force-pushed
the
phpunit-mock-class-name-matching
branch
2 times, most recently
from
3b2aed5 to
1c7c9ad
Compare
derrabus
approved these changes
Sep 25, 2024
Instead of performing some fuzzy matching on the automatically generated mock name (the pattern varies between different PHPUnit versions) we can simply use the actual exact class name.
xabbuh
force-pushed
the
phpunit-mock-class-name-matching
branch
from
1c7c9ad to
2c99e00
Compare
alexandre-daubois
approved these changes
Sep 26, 2024
|
Thank you @xabbuh. |
stof
reviewed
Sep 26, 2024
| @@ -44,7 +44,7 @@ public function testItSendsTheMessageToAssignedSender() | |||
| /* @var SentStamp $stamp */ | |||
| $this->assertInstanceOf(SentStamp::class, $stamp = $envelope->last(SentStamp::class), 'it adds a sent stamp'); | |||
| $this->assertSame('my_sender', $stamp->getSenderAlias()); | |||
| $this->assertStringMatchesFormat('Mock_SenderInterface_%s', $stamp->getSenderClass()); | |||
| $this->assertStringMatchesFormat($sender::class, $stamp->getSenderClass()); | |||
There was a problem hiding this comment.
use assertEquals instead of matching a format then.
There was a problem hiding this comment.
see #58396, thanks @alexandre-daubois
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of performing some fuzzy matching on the automatically generated mock name (the pattern varies between different PHPUnit versions) we can simply use the actual exact class name.