-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mime] Update mime types #58807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mime] Update mime types #58807
Conversation
@@ -2770,7 +2830,7 @@ public function guessMimeType(string $path): ?string | |||
'mp21' => ['application/mp21'], | |||
'mp2a' => ['audio/mpeg'], | |||
'mp3' => ['audio/mpeg', 'audio/mp3', 'audio/x-mp3', 'audio/x-mpeg', 'audio/x-mpg'], | |||
'mp4' => ['video/mp4', 'video/mp4v-es', 'video/x-m4v'], | |||
'mp4' => ['application/mp4', 'video/mp4', 'video/mp4v-es', 'video/x-m4v'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one and the next one seem suspicious to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
application/mp4 is a registered mime type
- https://www.iana.org/assignments/media-types/application/mp4
- https://datatracker.ietf.org/doc/rfc4337/
Do you think we should add a special case for it to grant the first place to "video/mp4" (as we do for mp3 and audi) ?
'mp3' => ['audio/mpeg'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done it / cf last comment
Updated preferences for aac (same thing), mp4 and mpeg4 Yaml has changed due to our preferences (not sure why it did not in first commit, and a small new change for "vor" in the meanwhile) |
@@ -1249,7 +1278,7 @@ public function guessMimeType(string $path): ?string | |||
'application/xslt+xml' => ['xsl', 'xslt'], | |||
'application/xspf+xml' => ['xspf'], | |||
'application/xv+xml' => ['mxml', 'xhvml', 'xvml', 'xvm'], | |||
'application/yaml' => ['yaml', 'yml'], | |||
'application/yaml' => ['yml', 'yaml'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not change this one as this is commonly used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i understand where the problem is coming from.
I updated the issue comment and added a comment in the update_mime_types.php file
(and fixed the MimeTypes.php file)
bfb8f75
to
1e8a2e0
Compare
Thank you @smnandre. |
I had to update the prefered extensions map in
src/Symfony/Component/Mime/Resources/bin/update_mime_types.php
This is the only way to make
If it's still possible before 7.2 ?
(last one was 8 months ago)