Skip to content

[Mailer] fix NativeTransportFactoryTest #59195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[Mailer] fix NativeTransportFactoryTest #59195

merged 1 commit into from
Dec 12, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 12, 2024

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

This is required as the ini_set() function is overwritten in the test to simulate a not-configured sendmail_path option.

This partially reverts #59173. Even if this violates our coding standards we have to keep it this way until we find another solution for the test.

This is required as the ini_set() function is overwritten in the test
to simulate a not-configured sendmail_path option.
@xabbuh xabbuh merged commit 31c4198 into symfony:7.3 Dec 12, 2024
7 of 11 checks passed
@xabbuh xabbuh deleted the pr-59173 branch December 12, 2024 11:04
@keradus
Copy link
Member

keradus commented Dec 13, 2024

thank you
5715d80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants