Bugfix for creating cookie on loginSuccess in AbstractRememberMeServices #6149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. Any feedback on this? |
fabpot
added a commit
that referenced
this pull request
Dec 2, 2012
This PR was merged into the master branch. Commits ------- 373be62 Bugfix for creating cookie on loginSuccess in AbstractRememberMeServices Discussion ---------- Bugfix for creating cookie on loginSuccess in AbstractRememberMeServices Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #6055 Todo: - License of the code: MIT By a mistake setting of new cookies did not work for other RememberMe services than PersistentTokenBasedRememberMeServices --------------------------------------------------------------------------- by TerjeBr at 2012-12-01T17:28:08Z Ping. Any feedback on this?
|
@fabpot will this now be a part of Symfony 2.2 ? |
|
It was merged into symfony/master, so it was not obvious to me that it would also be in 2.2 |
|
2.2 was created week ago (or around that) so all stuff merged before creation of this branch will be already in it. |
|
Ok, thank you for enlightening me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #6055
Todo: -
License of the code: MIT
By a mistake setting of new cookies did not work for other RememberMe services than PersistentTokenBasedRememberMeServices