[PropertyInfo] Fix getting type from constructor of parent class in PhpStanExtractor
#61752
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuchen90
force-pushed
the
fix-phpstan-extractor
branch
from
50e234d to
44a8112
Compare
OskarStark
changed the title
PhpStanExtractor
stof
reviewed
Sep 15, 2025
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
wuchen90
force-pushed
the
fix-phpstan-extractor
branch
from
44a8112 to
35e940e
Compare
nicolas-grekas
force-pushed
the
fix-phpstan-extractor
branch
from
35e940e to
63532f5
Compare
|
Thank you @wuchen90. |
| if (!$rawDocNode = $reflectionConstructor->getDocComment()) { | ||
| return null; | ||
| } | ||
| $class = $reflectionConstructor->class; |
There was a problem hiding this comment.
I updated the code to simplify the implementation and remove repeated code.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PhpStanExtractor fails when we try to resolve the type of a constructor argument that is declared in parent class.
It is mainly because the TypeContextFactory doesn't get all the
usesof parent classes.