[FrameworkBundle] Perform-no-deep-merging on workflow transitions' from/to configs #61757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Sep 15, 2025
nicolas-grekas
force-pushed
the
fwb-w-config
branch
from
955a0ba to
376d0a9
Compare
|
Status: needs work While adding tests, I figured out the normalization logic is broken, as highlighted by the failures when using XML. |
nicolas-grekas
force-pushed
the
fwb-w-config
branch
3 times, most recently
from
edd1296 to
3745417
Compare
nicolas-grekas
commented
Sep 16, 2025
| </xsd:sequence> | ||
| <xsd:attribute name="name" type="xsd:string" use="required" /> | ||
| <xsd:attribute name="name" type="xsd:string" /> | ||
| <xsd:attribute name="key" type="xsd:string" /> |
There was a problem hiding this comment.
In XML, we have to differentiate the name and the key of transitions, so that deep-merging them works the same way as in other config formats (appending numeric keys and recursing into associative ones).
/cc @jakubtobiasz FYI this is how you'll be able to leverage this fix - use attribute "key" instead of "name" if you use the XML format to define workflows.
nicolas-grekas
force-pushed
the
fwb-w-config
branch
from
3745417 to
688a045
Compare
nicolas-grekas
force-pushed
the
fwb-w-config
branch
from
688a045 to
66fff01
Compare
nicolas-grekas
commented
Sep 16, 2025
| $guardsConfiguration[$eventName][] = new Definition( | ||
| Workflow\EventListener\GuardExpression::class, | ||
| [new Reference($transitionId), $transition['guard']] | ||
| ); |
There was a problem hiding this comment.
too many intermediary variables made me wonder about this piece of code for too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #61596 but for transitions.
Also replaces #57873 per @stof's comment at #57873 (comment)