[FrameworkBundle] add test for #5135 and simplify routing container parameter resolution #9370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tobion
commented
Oct 24, 2013
Tobion
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixes | #5135 |
| Tests pass? | yes |
| license? | MIT |
- [FrameworkBundle] added working test case for issue Routing, default {_locale} pararameter and link to index #5135
- [FrameworkBundle] fix routing container parameter exception message which did not really make sense and improve regex performance
| $key = strtolower($match[1]); | ||
|
|
||
| if (!$container->hasParameter($key)) { | ||
| throw new ParameterNotFoundException($key); |
There was a problem hiding this comment.
strtolower and ParameterNotFoundException is already handled by Container::getParameter
also improve regex performance and fix implementation-specific written tests and typo
fabpot
added a commit
that referenced
this pull request
Oct 31, 2013
… container parameter resolution (Tobion) This PR was merged into the 2.2 branch. Discussion ---------- [FrameworkBundle] add test for #5135 and simplify routing container parameter resolution | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixes | #5135 | Tests pass? | yes | license? | MIT 1. [FrameworkBundle] added working test case for issue #5135 2. [FrameworkBundle] fix routing container parameter exception message which did not really make sense and improve regex performance Commits ------- 719e037 [FrameworkBundle] fix routing container parameter exception message 8513ac9 [Routing] added working test case for issue #5135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.