[Swup] For Swup's dev dependencies exclusion from our yarn.lock #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
Kocal
force-pushed
the
imp-swup-remove-their-dev-dependencies
branch
from
3c7ecaa to
ae52ae5
Compare
Kocal
commented
Sep 28, 2024
Comment on lines
+31
to
+36
| "@swup/prettier-config": "link:node_modules/.cache/null", | ||
| "@swup/browserslist-config": "link:node_modules/.cache/null", | ||
| "microbundle": "link:node_modules/.cache/null", | ||
| "prettier": "link:node_modules/.cache/null", | ||
| "shelljs": "link:node_modules/.cache/null", | ||
| "shelljs-live": "link:node_modules/.cache/null" |
There was a problem hiding this comment.
I wasn't able to configure Yarn resolutions to be more precise about what dependencies I want to remove, something like "@swup/plugin/microbundle": "link:node_modules/.cache/null".
Do to that, I think we must upgrade to Yarn Berry
|
Thanks a lot @Kocal 😃 |
Kocal
added a commit
that referenced
this pull request
Jul 21, 2025
This PR was merged into the 2.x branch. Discussion ---------- Replace Yarn Berry by PNPM | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Purely internal, this PR replaces Yarn by PNPM for the following reasons: - when working on #2222, I tried to use PNPM instead but it was not possible to not install [Swup "dev"-dependencies](#2221), this is now possible - it is [more efficient and performant](https://pnpm.io/benchmarks), and better for your disk - it has more [features](https://pnpm.io/feature-comparison), better Workspaces support and [Catalogs](https://pnpm.io/catalogs) 🤩 - commands to release packages on npm are simpler For developers working on UX, [pnpm can be installed with Corepack](https://pnpm.io/installation#using-corepack) Note: the ~26k lines changed are mainly about lock files Commits ------- 17a4bb7 Replace Yarn Berry by PNPM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2219, I've noticed we had a very old Rollup version that we do not use at all.
The issue comes from Swup v3, which ship its building dependencies as prod dependencies, which means we install
microbundleand all its dependencies:This PR won't impact developers, it's only for our
yarn.lockwhich contains a bunch of useless dependencies, and some of them are vulnerable too (listed on https://github.com/symfony/ux/security/dependabot)