-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement start of musculotendon model in sympy.physics._biomechanics
#25567
Implement start of musculotendon model in sympy.physics._biomechanics
#25567
Conversation
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
🟠Hi, I am the SymPy bot. I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
LGTM, merging as private so we can get the full examples working. Will review in detail as we build out the examples and before we make _biomechanics public. |
This PR follows directly on from #25553 and should not be merged until #25553 has been merged.
References to other Issues or PRs
Forms part of the CZI biomechanics work program described in #24240. Follows on from #25553.
Brief description of what is fixed or changed
Introduces a new class,
MusculotendonDeGroote2016
, which implements musculotendon dynamics as a subclass ofsympy.physics.mechanics.actuator.ForceActuator
.This PR introduces two formulations for musculotendon dynamics:
0. Rigid tendon.
Boilerplate is also added to support other musculotendon dynamics formulations in the future:
2. Explicit elastic tendon (using tendon force as the state variable).
3. Implicit elastic tendon (using muscle fiber length as the state variable and muscle fiber velocity as the additional input variable).
4. Implicit elastic tendon (using tendon force as the state variable and muscle fiber velocity as the additional input variable).
Other comments
This PR is pretty rough and ready as is mean to just get some form of musculotendon dynamics into the WIP
sympy.physics_biomechanics
module. Other PRs this month will add additional tests, complete docstrings etc.Release Notes
NO ENTRY