feature(agent): standardize the value used for driver selection (#1389)

Author: mavimo

charts/agent/templates/daemonset.yaml

@@ -98,7 +98,7 @@ spec:
           {{- end }}
           {{- if (include "agent.legacyEbpfEnforced" .) }}
             - name: SYSDIG_AGENT_DRIVER
-              value: legacy_bpf
+              value: legacy_ebpf
           {{- end }}
           {{- range $key, $value := .Values.daemonset.kmodule.env }}
             - name: {{ $key | quote }}
@@ -189,10 +189,10 @@ spec:
             {{- end }}
             {{- if (include "agent.universalEbpfEnforced" .) }}
             - name: SYSDIG_AGENT_DRIVER
-              value: universal_bpf
+              value: universal_ebpf
             {{- else if (and (include "agent.ebpfEnabled" .) (eq "legacy" .Values.ebpf.kind )) }}
             - name: SYSDIG_AGENT_DRIVER
-              value: legacy_bpf
+              value: legacy_ebpf
             {{- end }}
             {{- if (.Values.proxy.httpProxy | default .Values.global.proxy.httpProxy) }}
             - name: http_proxy

charts/agent/tests/universal_ebpf_test.yaml

@@ -40,12 +40,12 @@ tests:
           path: spec.template.spec.initContainers[*].env[?(@.name == "SYSDIG_BPF_PROBE")].value
       - equal:
           path: spec.template.spec.initContainers[*].env[?(@.name == "SYSDIG_AGENT_DRIVER")].value
-          value: legacy_bpf
+          value: legacy_ebpf
       - isEmpty:
           path: spec.template.spec.containers[*].env[?(@.name == "SYSDIG_BPF_PROBE")].value
       - equal:
           path: spec.template.spec.containers[*].env[?(@.name == "SYSDIG_AGENT_DRIVER")].value
-          value: legacy_bpf
+          value: legacy_ebpf
 
   - it: Ensure that when the eBPF is enabled and we specify to use the "universal" driver we create the sysdig container without the SYSDIG_BPF_PROBE and with the SYSDIG_AGENT_DRIVER environment variables
     set:
@@ -57,7 +57,7 @@ tests:
           path: spec.template.spec.containers[*].env[?(@.name == "SYSDIG_BPF_PROBE")]
       - equal:
           path: spec.template.spec.containers[*].env[?(@.name == "SYSDIG_AGENT_DRIVER")].value
-          value: universal_bpf
+          value: universal_ebpf
 
   - it: Ensure that when the eBPF is enabled and we specify to use the "universal" driver we don't create the init container
     set: