chore(agent,sysdig-deploy): set promscrape port to 9091 by default when gke autopilot is enabled #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroberts87
reviewed
Feb 20, 2024
Comment on lines
50
to
52
| {{- if and (include "agent.gke.autopilot" .) (or (not (hasKey $baseSettings "promscrape_web_address")) (eq (get $baseSettings "promscrape_web_address") "127.0.0.1:9990") ) }} | ||
| {{- $baseSettings := mergeOverwrite $baseSettings (dict "promscrape_web_address" "127.0.0.1:9991") -}} | ||
| {{- end }} |
Collaborator
There was a problem hiding this comment.
This should not be needed. prometheus.enabled is set to false earlier in the configuration, and promscrape will not run in that situation.
cc @thom-sd
Contributor
Author
There was a problem hiding this comment.
nice catch, thanks!
Co-authored-by: Javier Fuster <fusti92@gmail.com>
aroberts87
approved these changes
Feb 21, 2024
francesco-furlan
deleted the
chore/set-promscrape-port-when-autopilot-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.