Skip to content

Conversation

vicLin8712
Copy link
Collaborator

Issue

The current comment incorrectly suggested that CLINT timer is controlled by MIE.MEIE.

Refer to RISC-V Privileged Spec, section 3.1 "Machine-Level CSRs v1.13" (p.43), the CLINT timer interrupt is controlled by MIE.MTIE (bit 7), while MIE.MEIE (bit 11) is for external interrupts.

Fix

Updated the comment to clarify that MIE.MEIE enables external interrupts (e.g., UART).

Copy link
Collaborator

@visitorckw visitorckw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use a file name prefix in the subject line; otherwise LGTM.

@vicLin8712 vicLin8712 changed the title boot.c: revise comment of MIE.MEIE Revise comment of MIE.MEIE Sep 7, 2025
@vicLin8712
Copy link
Collaborator Author

Fixed the subject line as requested.👍

@jserv jserv merged commit d6232aa into sysprog21:main Sep 7, 2025
@jserv
Copy link
Contributor

jserv commented Sep 7, 2025

Thank @vicLin8712 for contributing!

@visitorckw
Copy link
Collaborator

When looking at the git log today, I noticed that this PR's commit only contains a one-line subject title.
IMHO, the PR description does a good job explaining why the previous implementation was incorrect, but unfortunately, that context is missing from the git commit message itself.
For future reference, I’d prefer if this kind of reasoning could also be included in the git commit message, so it's preserved in the changelog.

@vicLin8712 vicLin8712 deleted the fix-mie-comment branch September 17, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants