Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase on coreboot 24.08 #225

Closed
crawfxrd opened this issue May 31, 2024 · 3 comments · Fixed by #238
Closed

Rebase on coreboot 24.08 #225

crawfxrd opened this issue May 31, 2024 · 3 comments · Fixed by #238
Assignees

Comments

@crawfxrd
Copy link
Member

crawfxrd commented May 31, 2024

24.05 has some critical fixes for functionality on MTL (many cherry-picked to our 24.02 base) and upstreams many of our fixes.

@crawfxrd crawfxrd self-assigned this May 31, 2024
@crawfxrd
Copy link
Member Author

crawfxrd commented May 31, 2024

Evalualtion of commits from 24.02 base.

  • U: Commit exists in upstream main (but not necessarily in the 24.05 tag)
  • F: Commit is or should be applied as a fix-up commit to the listed CB change
  • D: Commit should be dropped

  • [U] CB:82246 792996f mb/system76/tgl: Update VBT to version 250
  • [F] f65d2ab Add lemp13-b
    • Fix-up commit for "Add System76 Lemur Pro (lemp13)"
  • [F] CB:82609 | 552e524 Add darp10-b
  • CB:82609 | 49122b0 mb/system76/mtl: Add Darter Pro 10 as a variant
  • [F] CB:82609 | 8cd1045 mb/system76/mtl: Fix crashlog
  • 7dbc405 soc/intel/mtl: Set HDA subsystem ID during FSP-M
    • Depends on our version of FSP (UPD not present upstream yet)
  • [U] CB:82071 | 2ff8127 include/device/pci_ids.h, soc/intel/mtl: add new MTL-P iGPU DID
  • [U] CB:81954 | 3a66a8e cpu/intel/microcode: Defer microcode patching until after DRAM init
  • [U] CB:81336 | d462108 cpu/x86/mtrr: Error out caching limitation during NEM
  • [U] CB:81271 | 9dad323 soc/intel/mtl: Enable RAMTOP caching at SoC level for MTL devices
  • [U] CB:81269 | 4a0c8c4 soc/intel/cmn/ramtop: Refactor MTRR handling for RAMTOP range
  • [U] CB:81268 | fc17805 arch/x86: Add API to check if cache sets are power-of-two
  • [U] CB:80693 | 568ef48 drivers/mrc_cache: Deselect MRC_CACHE_USING_MRC_VERSION by default
  • [U] CB:80728 | 65b8b55 soc/intel/meteorlake: Select MRC_CACHE_USING_MRC_VERSION
  • [U] CB:81641 | 6a6f7f8 mb/system76: Update CMOS layouts
  • [F] 7114256 lemp13: disable CPU C10 reporting
    • Fix-up commit for "Add System76 Lemur Pro (lemp13)"
  • [F] 30ee8e1 lemp13: use SPD size of 1024 bytes
    • Fix-up commit for "Add System76 Lemur Pro (lemp13)"
  • 160f0f9 Ensure that full DDR5 SPD is read
  • [D] 9c1710a Revert "soc/intel/meteorlake: Disable MRC fast boot"
    • Related issue was fixed
  • 37241d7 soc/intel/common/block/cse: prevent HECI commands when flash descriptor override is set
  • 7beec0b soc/intel/meteorlake: increase cbfs and preram cbmem console sizes
  • [D] 22a3cb7 soc/intel/meteorlake: Disable MRC fast boot
    • Related issue was fixed
  • b1996b2 soc/intel/meteorlake: Correctly set Usb4CmMode
  • [F] CB:82596 | a176798 mb/system76/rpl: oryp12: Disable AER on TBT port
  • [U] CB:82596 | 9bd47b4 mb/system76/rpl: Add Oryx Pro 12 as a variant
  • bcd3446 Add System76 Lemur Pro (lemp13)
  • d876776 soc/intel/adl,mtl: Use channel 0 only for memory down in mixed topo
  • [U] CB:82730 | 960bfe9 soc/intel/meteorlake: set PortResetMessageEnable appropriately
  • d14c9c6 soc/intel/meteorlake: Hook up GMA ACPI brightness controls
  • [U] CB:82685 | b8bf900 soc/intel/meteorlake: set PchHdaAudioLinkHdaEnable
  • 7480a5a soc/intel/meteorlake: Expand DDR5 channels like soc/intel/alderlake
  • [U] CB:81126 | b37a24f drivers/i2c/tas5825m: Use I2C instead of SMBus
  • [U] CB:80790 | f3ecbae lib/rtc: Fix off-by-one error in February day count in leap year
  • [U] CB:80719 | e8df441 soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL
  • [U] CB:80665 | e824c88 soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
  • [U] CB:80665 | f7cea30 soc/intel/adl: Set slp-s0 counter frequency
  • [U] CB:80486 | 566623f soc/intel/alderlake: Sync UPD Usb4CmMode with Kconfig
  • [F] CB:82727 | 2c8c5cf mb/system76/rpl: Fix typo
  • [F] CB:82727 | c70505f mb/system76/rpl: addw4: Set dynamic boost values
  • [U] CB:82595 | 7df4732 mb/system76/rpl: Add Adder WS 4 as a variant
  • [U] CB:80754,CB:80755 | 6ab4a72 mb/system76/adl,rpl: Fix HDA codec init
  • [F] CB:57034 | 38c3eda drivers/intel/dtbt: Fix build after rebase
  • [F] CB:75286 | 4a27416 drivers/gfx/nvidia: Fix build after rebase
  • [U] CB:80791 | 60f3d71 Resolve ACPI BIOS Errors for RPL systems
  • [U] CB:80756 | d6d4c5e mb/system76/adl,rpl: Add timeouts for PCIe 3.0 RPs
  • [D] 5b13dc0 drivers/smmstore/ramstage.c: retry smmstore init up 5 times
  • [U] CB:82597 | f941def mb/system76/rpl: darp9: Add SSD RTD3 configs
  • b413691 mb/system76: Add custom CMOS default for darp8,darp9
  • e96476d mb/system76: Enable S0ix for darp8/darp9
  • 9113e14 mb/system76: Enable EC lockdown on TGL+
  • bb54e49 ec/system76: Support lockdown based on EC security state
  • CB:82727 | be0dfcd mb/system76: Enable dGPUs
  • CB:57034 | ed92a6d drivers/gfx/nvidia: Add driver for NVIDIA GPU
  • b21bd87 soc/intel/alderlake: Add IRQ for non-existent CPU PCIe device
    • Fixed upstream?
  • CB:61410 | f224ddb mb/system76/bonw14: Enable TAS5825M smart amp
  • CB:76584 | e3033b5 mb/system76/rpl: Enable discrete TBT device
  • CB:75286 | cfa8635 drivers/intel/dtbt: Add discrete Thunderbolt driver
  • CB:75283 | 868c102 lib,soc/intel/common/block/smbus: Use a SPD length of 512 bytes for DDR5
  • CB:75284 | f6ed868 soc/intel/adl: Fill in SPD data on both channels of DDR5 memory
  • CB:52731 | 920d350 soc/common/smbus: Add support for reading spd data via smbus for DDR5
  • d241bc9 soc/intel/alderlake: Hack to preserve SBREG
  • CB:75878 | 70657e3 security/tpm/tspi: Do TPM Restart if TPM Resume fails
  • CB:50598 | 8d5df37 intel/block/pcie/rtd3: Also implement _PR3
  • ed35db9 intel/block/pcie/rtd3: ACPI debug messages
    • Not required; drop it?
  • f2182a3 submodules: Use absolute paths

@crawfxrd
Copy link
Member Author

crawfxrd commented May 31, 2024

Pick from main

  • a8fdafa ("cpu/x86/pae/pgtbl.c: remove dead paging_identity_map_addr()")
  • 62a6188 ("soc/intel/meteorlake: Add PsysPL2 configuration")
  • bfc92cb ("device: drop unnecessary CHECK_REV_IN_OPROM_NAME option")
  • 8ed95c3 ("device/pci_rom: handle non-remapped VGA_BIOS_ID")
  • 5ba17d5 ("security/memory_clear: fix wrong size of reserved memory range")
  • bd33b6a ("include/device: Fix IO resource handling covering 0xFFFF")
  • 5d1494a ("mb/system76/tgl: Update VBTs to version 250")
  • 3a4e139 ("mb/system76/rpl: darp9: Add SSD RTD3 configs")
  • 8b9716e ("mb/system76/rpl: Add Oryx Pro 12 as a variant")
  • 29f1b79 ("mb/system76/rpl: Add Adder WS 4 as a variant")
  • 3a26aec ("soc/intel/meteorlake: Hook up PchHdaAudioLinkHdaEnable to devicetree")
  • 8093b77 ("mb/system76: Add SPDX ID to devicetree files")
  • cfcd085 ("mb/system76/rpl: Hook up TAS5825M init")
  • ed55218 ("mb/system76/rpl: Fix addw4 Kconfig name")
  • 657cef2 ("soc/intel/meteorlake: Enable USB2 port reset message on Type-C ports")

Pick from system76-24.02

  • f2182a3 ("submodules: Use absolute paths")
  • [?] ed35db9 ("intel/block/pcie/rtd3: ACPI debug messages")
  • [?] d241bc9 ("soc/intel/alderlake: Hack to preserve SBREG")
  • [?] b21bd87 ("soc/intel/alderlake: Add IRQ for non-existent CPU PCIe device")
  • bb54e49 ("ec/system76: Support lockdown based on EC security state")
  • 9113e14 ("mb/system76: Enable EC lockdown on TGL+")
  • e96476d ("mb/system76: Enable S0ix for darp8/darp9")
  • b413691 ("mb/system76: Add custom CMOS default for darp8,darp9")
  • d876776 ("soc/intel/adl,mtl: Use channel 0 only for memory down in mixed topo")
  • 7beec0b ("soc/intel/meteorlake: increase cbfs and preram cbmem console sizes")

Pick from gerrit

  • CB:50598 ("intel/block/pcie/rtd3: Also implement _PR3")
  • CB:75878 ("security/tpm/tspi: Do TPM Restart if TPM Resume fails")
  • CB:52731 ("soc/common/smbus: Support reading SPD5 hubs for DDR5")
  • CB:75284 ("soc/intel/adl: Fill in SPD data on both channels of DDR5 memory")
  • CB:82733 ("soc/intel/mtl: Fill in SPD data on both channels of DDR5 memory")
  • CB:75286 ("drivers/intel/dtbt: Add discrete Thunderbolt driver")
  • CB:76584 ("mb/system76/rpl: Enable discrete TBT device")
  • CB:57034 ("drivers/gfx/nvidia: Add driver for NVIDIA GPU")
  • CB:82727 ("mb/system76: Enable dGPUs")
  • CB:61410 ("mb/system76/bonw14: Enable TAS5825M smart amp")
  • CB:77567 ("soc/intel/meteorlake: Correctly set Usb4CmMode")
  • CB:82728 ("soc/intel/common/block/cse: Prevent HECI commands when flash descriptor override is set")
  • CB:82729 ("soc/intel/mtl: Hook up GMA ACPI brightness controls")
  • CB:82731 ("soc/intel/mtl: Set HDA subsystem ID during FSP-M")
  • CB:82609 ("mb/system76/mtl: Add Darter Pro 10")
  • CB:82788 ("mb/system76/mtl: Add Lemur Pro 13")

@crawfxrd
Copy link
Member Author

crawfxrd commented Aug 30, 2024

Rebase on 24.08

Pick from main

  • 19a22e3 ("soc/intel/adl: Prevent unconditional legacy COM ports initialization")
  • 853b903 ("Update intel-microcode submodule to upstream main")
  • 610c0d0 ("3rdparty/blobs: Update submodule to upstream main")
  • f373188 ("soc/intel/raptorlake: Use updated microcode from blobs repo")

Pick from gerrit

  • CB:82729: soc/intel/mtl: Hook up GMA ACPI brightness controls
  • CB:52731: soc/common/smbus: Support reading SPD5 hubs for DDR5
  • CB:75284: soc/intel/adl: Fill in SPD data on both channels of DDR5 memory
  • CB:82733: soc/intel/mtl: Fill in SPD data on both channels of DDR5 memory
  • CB:57034: drivers/gfx/nvidia: Add driver for NVIDIA GPU
  • CB:75286: drivers/intel/dtbt: Add discrete Thunderbolt driver
  • CB:77567: soc/intel/meteorlake: Correctly set Usb4CmMode
  • CB:82731: soc/intel/mtl: Set HDA subsystem ID during FSP-M
  • CB:82729: soc/intel/mtl: Hook up GMA ACPI brightness controls
  • CB:83696: mb/system76/mtl: darp10: Add TCSS configs
  • CB:83696: mb/system76/mtl: Add Lemur Pro 13
  • CB:82728: soc/intel/common/block/cse: Prevent HECI commands when flash descriptor override is set
  • CB:84149: mb/system76/rpl: bonw15: Update GPIOs
  • CB:84150: mb/system76/rpl: Add bonw15-b variant
  • CB:76584: mb/system76/rpl: Enable discrete TBT device
    • Update for bonw15-b
  • CB:82727: mb/system76: Enable dGPUs
    • Update for bonw15-b
  • CB:84224: mb/system76/mtl: Enable gfx register for GMA ACPI

Pick from system76-24.02

  • d876776 ("soc/intel/adl,mtl: Use channel 0 only for memory down in mixed topo")
  • 7beec0b ("soc/intel/meteorlake: increase cbfs and preram cbmem console sizes")
  • bb712a7 ("ec/system76/ec: Add config for 2nd fan without dGPU")
  • bb54e49 ("ec/system76: Support lockdown based on EC security state")
  • bb712a7 ("ec/system76/ec: Add config for 2nd fan without dGPU")
  • 9113e14 ("mb/system76: Enable EC lockdown on TGL+")
    • Update for MTL
  • b413691 ("mb/system76: Add custom CMOS default for darp8,darp9")
  • e96476d ("mb/system76: Enable S0ix for darp8/darp9")

Add the following

  • mb/system76/mtl: Enable EnableTcssCovTypeA configs

@crawfxrd crawfxrd changed the title Rebase on coreboot 24.05 Rebase on coreboot 24.08 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant