Repository navigation
Releases
Releases · szautkin/CanfarDesktopUbuntu
v1.4.4
Full Changelog: v1.4.3...v1.4.4
Full Changelog: v1.4.3...v1.4.4
v1.4.3
Verbinal for Linux 1.4.2
A release about being told the truth. An agent asking for something impossible
was answered "done"; the ADQL checker shipped last week had never once run,
because its schema fetch panicked the main thread on the way in; the About
window's Runtime Info named the app's own version as the Rust version and gave
no version at all for GTK. Underneath, three pieces of code that existed twice
now exist once — including a whole streaming download whose copy had quietly
missed out on cancellation.
The compiler is pinned, so the gates mean what they say
- The README promised that
cargo clippy --all-targets -- -D warningsis "the
exact command CI runs, so a green local run means a green CI run". The command
was exact; the compiler was not. CI tookdtolnay/rust-toolchain@stable— the
day's stable — and a developer had whatever stable they last updated to. - Rust 1.98 added
clippy::chunks_exact_to_as_chunks, and three call sites that
had been in the tree for months went red in CI while staying green on a 1.97
desktop. No amount of care locally would have found it: a lint that does not
exist on your machine cannot fire on your machine. rust-toolchain.tomlnow pins the version, both workflows install that
version, and a test fails if the three copies drift. The three sites use
as_chunks::<4>(), andrust-versionrecords the 1.88 floor the code needs.
What the app does, described as it actually is
- The feature list was written when there were seven of them. It ran the
Portal's own minutiae (Auto-Refresh, Recent Launches) alongside whole
applications (FITS Viewer, Archive Search) as thirteen equal bullets, and left
out Research, Workflows, the AI Guide, finding an image by package, figure
export and the ADQL editor entirely. It is now written by area, the way the
app presents itself on its Home page. - The AppStream description — what a software centre shows — gained the same
areas. It had described two viewers and an agent, which was a third of the app. - Counts that came from one screenshot ("368 images", "17106 entries") are
described by their scale instead, because the numbers change and the README
does not.
The ADQL checker had never run
- The schema fetch that feeds it was awaited on the GLib main context, where
there is no tokio reactor, so it panicked the main thread the moment the
Search page was built — "there is no reactor running". The schema therefore
never arrived,cached()stayed empty, and the checker, which says nothing
when it has nothing to check against, said nothing. A check that silently
never runs is the worst way for one to fail: from the outside it is
indistinguishable from a query with no problems. - The fetch now goes through the tokio runtime like every other request. The
editor underlines the offending words, and Execute greys out, from a cold
start — which is what the previous release said it did. validate_adql_queryandexecute_adql_querywere unaffected: they fetch the
schema themselves, on the runtime, which is why the tool worked while the
editor did not.
About points at the project, and says what it is running on
- About and Help open verbinal.com, the project's own
page, rather thancanfar.net— that is the SERVICE this app talks to, and the
two answer different questions. About also carries a "Report an Issue" link to
the tracker and a support address, so a report arrives with a version beside it
instead of "the latest one". - Runtime Info names the versions a bug report needs. It said "Rust
{app version}" — the app's own version wearing the toolchain's label — and
"GTK4 + libadwaita" with no version at all, so the one section meant to help
someone report a bug named nothing that varies between the machines where a bug
appears. It now reads the real GTK and libadwaita versions at run time. - The project's addresses live in one place with a test that the packaging, the
metainfo and the README all name the same ones; nothing compiles those three,
so a moved page would otherwise be found by a person landing on a 404.
One implementation of a download, and of a sky coordinate
No behaviour was meant to change here, but one did, for the better.
- The Search page had its own private copy of the whole streaming download —
191 lines, doc comments and all, forked fromservices::transferand since
drifted: the original grew cancellation support and the copy did not. Saving an
observation to Research now runs the same code every other transfer does. - Four sky-coordinate formatters existed twice, in
cube_axesand again in
cube_export, whose copy was justified in a comment as being there "so the
footer ranges match the live axis captions verbatim" — the one guarantee that
copying them cannot give. They now live once, inhelpers::sexagesimalbeside
their long-form siblings, with a test that no file grows a private copy again. - The two readers that decide what counts as a number now share one definition,
so a tool that validates with one and applies with the other cannot disagree.
An agent can see what a dropdown offers, and a bad value is refused
rowsPerPageOptionsreports the Rows/page menu — 25, 50, 100, 250, 500 —
beside the size in force. Any whole number from 1 to 1000 is still accepted;
the menu is the menu, not the limit.- Each column reports its own display
units, so a caller picks one instead
of guessing and reading the refusal. RA offers hms/degrees, Int. Time offers
seconds through days, the spectral columns offer fourteen. - A value that is not a whole number is refused rather than ignored.
{"rowsPerPage": "abc"}used to report success and change nothing, because
the reader answered "absent" for both missing and unreadable."42"is still
accepted — agents send that routinely — but12.5,nulland"abc"are
now refused, saying what was wanted and what arrived.
A hand-written query keeps the columns it selected
SELECT target_name, collectioncame back ascollectionalone — the
target silently dropped — whileSELECT target_name, typecame back with
both. Adding a recognised column to a query made the others disappear. The
column-visibility preference is about the SEARCH FORM's own result shape, and
applying it to an arbitrary query filtered out every column it had never
heard of. A result that is not the form's shape now shows everything it
returned.set_search_results_viewreportsrowColumns. It answers without rows —
a hundred of them on every column toggle is a lot of wire for a confirmation —
and it used to drop the header list with them, so revealing a column and then
checking the reply looked like nothing had happened.
validate_adql_query — check a query without spending one
- The same check the editor and
execute_adql_queryrun, offered on its own, so
an agent composing a query can ask whether it is acceptable instead of finding
out by running it. It returns each problem with the text it objects to and,
where there is one obvious answer, what to write instead. It does not touch
the ADQL editor: checking a draft should not replace what someone has open.
An ADQL query is checked against the service's own schema before it is sent
- The mistake that prompted it:
FROM caom2.Observation JOIN caom2.Plane ON Plane.obsID=Observation.obsIDis refused by CADC with "Column [obsID] is
ambiguous", because a bare table name is only a valid qualifier while the
column it names belongs to one of the joined tables. WritingAS por
caom2.Plane.obsIDboth work. - The offending words are underlined in the editor, the reason and the fix are
shown beside the title, and Execute is greyed until the query is one the
service would accept. The same check runs onexecute_adql_query, so an
agent's query is refused with the reason instead of spending a round trip. - It only reports what it is sure of. A subquery, a function, a table the
schema has not been fetched for — each is left alone, because a false positive
here disables Execute on a query that would have worked.
Several rows at once, and a metadata sheet you can read
- Multiple selection. Click picks one row, Ctrl-click adds or removes one,
Shift-click takes the range — and neither modifier opens the dialog, because
adding a fourth row to a comparison should not put a window over the three
being read.selectRowtakes one index, an array of them, or null, and
get_search_resultsreportsselectedRows. - The row dialog's metadata is in two columns, with one heading above both
so they start at the same height. A row has 41 columns and the dialog shows
every non-empty one, which was a list to scroll rather than a sheet to read.
A results row can be highlighted, and its dialog opened, from MCP
selectRowhighlights one row of the filtered results and pages to it, so
"this one" means something to the person looking at the window. Clicking a row
highlights it too, andget_search_resultsreportsselectedRow.show_search_row_detailopens the detail dialog for the highlighted row —
every column of it, the same window a click gives.- The Rows/page dropdown follows the model. Setting the page size over MCP
changed the model and not the control, so it read "Rows/page: 100" above a bar
counting "31-40 of 60". The size is set in one place now, and that place moves
the dropdown.
A stack buffer overflow in the FITS error path
- Opening a FITS file that produced a long cfitsio error crashed the app.
ffgmsgwrites up to 81 bytes into the buffer it is handed, and both call
sites gave it a 31-byte stack array — so any message longer than thirty
characters wrote up to fifty bytes past the end of it. "failed to find or open
the following fil...