Skip to content

Refactor the refresh sample to be more explicit #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2018
Merged

Refactor the refresh sample to be more explicit #288

merged 1 commit into from
Apr 17, 2018

Conversation

graysonarts
Copy link
Contributor

No description provided.

LGraber
LGraber approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@LGraber LGraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you have the resource_id, you could just contruct the object and pass it in. I don't remember why I took the object and not the id here. We should be more consistent. Oh well.

@graysonarts graysonarts merged commit d28d5fc into tableau:development Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LGraber LGraber LGraber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graysonarts @LGraber