Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for embed_password field and allow updating value to false #416

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

shinchris
Copy link
Contributor

Added proper parsing of the 'embed_password' field of ConnectionItem.
Also added a fix to allow 'embed_password' field to be updated correctly with the update datasource connection endpoint.

Copy link
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shinchris shinchris merged commit 6907a15 into development Apr 2, 2019
@shinchris shinchris deleted the embedpassword_fix branch April 2, 2019 21:39
@graysonarts graysonarts mentioned this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants