android,libtailscale: implement key.HardwareAttestationKey #694
Conversation
awly
force-pushed
the
awly/hardware-attestation-key
branch
from
39758eb to
67a2b0b
Compare
There was a problem hiding this comment.
I'll defer to @patrickod for the rest, but I do have an ask:
| // HardwareKeyStore implements the callbacks necessary to implement key.HardwareAttestationKey on | ||
| // the Go side. It uses KeyStore with a StrongBox processor. | ||
| class HardwareKeyStore() { | ||
| var keyStoreKeys = HashMap<String, KeyPair>(); |
There was a problem hiding this comment.
Can we only instantiate this HashMap when the feature is actually available?
There was a problem hiding this comment.
ooc is this a memory optimization or a compatibility concern?
There was a problem hiding this comment.
I made the whole class instantiation conditional in https://github.com/tailscale/tailscale-android/pull/694/files#diff-c4efae6d7bd6aa6cee62e464f666eee2c22556ca45aeb390c46b2eb6580d0dcdR375-R381
(hopefully that's the correct way to do it 😅 )
There was a problem hiding this comment.
@patrickod memory optimization -- in the sense that my rule of thumb for mobile is "don't hang onto resources any longer than you need them"
awly
force-pushed
the
awly/hardware-attestation-key
branch
from
67a2b0b to
7e8548c
Compare
Use a KeyStore-backed key to store a hardware-bound private key. Updates tailscale/tailscale#15830 Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
awly
force-pushed
the
awly/hardware-attestation-key
branch
from
7e8548c to
a78c07a
Compare
Use a KeyStore-backed key to store a hardware-bound private key.
Updates tailscale/tailscale#15830