Improve transition naming #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RobinMalfait
commented
Apr 13, 2021
RobinMalfait
commented
- rename Transition to TransitionRoot
- alias Transition.Root to Transition
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/D8Rvj2fa6tUjL3UakyRRgEKD7iGi headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/G41RrYyjqK6zuJ8cR7RweYSJAKR7 |
RobinMalfait
force-pushed
the
improve-transition-naming
branch
from
8611c8b to
793ba6c
Compare
This will allow us to write it as: - TransitionRoot - TransitionChild This has the added benefit that it doesn't collide with the internal Transition component from Vue itself.
This allows us to write: - Transition.Root - Transition.Child If you have a standalone Transition, then you can still use <Transition /> as is.
RobinMalfait
force-pushed
the
improve-transition-naming
branch
from
835c858 to
4b2e76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.