Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve aria accessibility #592

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Improve aria accessibility #592

merged 4 commits into from
Jun 4, 2021

Commits on Jun 4, 2021

  1. encode expected aria-expanded behaviour

    @RobinMalfait
    RobinMalfait committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    e906e5f View commit details
    Browse the repository at this point in the history

  2. ensure aria-expanded has the correct value 

    `aria-expanded` can be in 3 different states:

| Value               | Description                                                                |
| ------------------- | -------------------------------------------------------------------------- |
| false               | The grouping element this element owns or controls is collapsed.           |
| true                | The grouping element this element owns or controls is expanded.            |
| undefined (default) | The element does not own or control a grouping element that is expandable. |

Ref: https://www.w3.org/TR/wai-aria-1.2/#aria-expanded

Fixes: #580
    @RobinMalfait
    RobinMalfait committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    6c7db75 View commit details
    Browse the repository at this point in the history

  3. ensure disabled prop in Vue is not rendered when false

    @RobinMalfait
    RobinMalfait committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    839560c View commit details
    Browse the repository at this point in the history

  4. update changelog

    @RobinMalfait
    RobinMalfait committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    6d6f710 View commit details
    Browse the repository at this point in the history