Sort arbitrary variants deterministically regardless of content order #10016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This didn’t actually have any negative effect because of how it was implemented. But it only happened to work right :D
thecrypticace
force-pushed
the
fix/deterministic-arbitrary-variant-sorting
branch
from
428f560
to
89da23f
Compare
We really only care that the order is _always_ the same. localeCompare is still locale dependent based on environment. This ensures it’s dependent on content only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently arbitrary variants are non-deterministic in their sorting given multiple environments or different sets of content. For example, if you run your build on your local environment in Windows and then again in CI which is on Linux it is possible that you can get different built output and different sorting for utilities using arbitrary variants.
This change ensures that utilities using arbitrary variants are sorted in a deterministic manner (by byte, ascending). Given that arbitrary variants are registered on-demand when they are found it complicates the sorting process a bit but it's still fairly reasonable.
This should fix the problem noted here: tailwindlabs/prettier-plugin-tailwindcss#106