Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stroke-width plugin #1094

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Conversation

Larissagilliane
Copy link

@Larissagilliane Larissagilliane commented Aug 22, 2019

This pull request is addressing the changes proposed by @tillkruss at #1074.
I don't know if this issue is neccessary but i went ahead and did it anyways.

I hope it is usefull and the code is enough.

This is a example of the new plugin:
printscreen

Closes #1074

@adamwathan

@mrcsmcln
Copy link

mrcsmcln commented Nov 7, 2019

Not sure if this has been discussed yet, but would it make more sense to have the class names reflect the border convention? For example, stroke (for 1px), stroke-0, stroke-2, stroke-4, etc.

@adamwathan adamwathan merged commit ba640fc into tailwindlabs:master Dec 30, 2019
@adamwathan
Copy link
Member

Thanks! Renamed the utility to just stroke-{width} to shorten it a bit and just used 0, 1, and 2 as the default values, with no units 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add stroke-width
7 participants