Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oxide] Ensure generated tailwind.config.js file is formatted properly #11221

Merged
merged 2 commits into from
May 12, 2023

Conversation

RobinMalfait
Copy link
Member

This PR fixes a small formatting issue when generating the tailwind.config.js file when using the npx tailwindcss init command using the oxide engine.

We dropped the content: [] by default such that the auto content detection can be used as a default. However we used a regex to replace the content: [] which included a \s in the regex.
This is problematic because \s includes \n so therefore the previous \n was removed as well.

Everything still worked, but the formatting of the generated file was off.

The `\s` regex includes newlines `\n`, but we only want leading spaces
to be removed.
@RobinMalfait RobinMalfait changed the title [Oxide] Ensure generated tailwind.config.js is formatted properly [Oxide] Ensure generated tailwind.config.js file is formatted properly May 12, 2023
@RobinMalfait RobinMalfait merged commit 0e171fd into master May 12, 2023
@RobinMalfait RobinMalfait deleted the fix/config-file-formatting branch May 12, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant