Fix source maps issue resulting in a crash #11319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/source-maps
branch
2 times, most recently
from
b707d61
to
4c85145
Compare
RobinMalfait
commented
May 30, 2023
| '13:8 -> 22:8', | ||
| '13:31 -> 23:0', | ||
| ]) | ||
| expect(annotations).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Now that we don't use crosscheck anymore, we can use toMatchInlineSnapshot again!
RobinMalfait
force-pushed
the
fix/source-maps
branch
4 times, most recently
from
ecf472c
to
293dd8a
Compare
RobinMalfait
force-pushed
the
fix/source-maps
branch
from
293dd8a
to
900d859
Compare
RobinMalfait
commented
May 30, 2023
| @@ -38,33 +38,34 @@ test.skip('apply generates source maps', async () => { | |||
| // All CSS generated by Tailwind CSS should be annotated with source maps | |||
| // And always be able to point to the original source file | |||
| expect(sources).not.toContain('<no source>') | |||
| expect(sources.length).toBe(1) | |||
| expect(sources.length).toBe(2) | |||
There was a problem hiding this comment.
All of these are increased by 1. If you (temporarily) set the minify: false to minify: true in the lightningCssPlugin then it goes down by 1 again.
There was a problem hiding this comment.
the number of sources should definitely just be 1
Introducing additional sources that disappear during minification sounds like a lightningcss bug. I'll set up an isolated test case for that and file a bug report.
RobinMalfait
force-pushed
the
fix/source-maps
branch
from
900d859
to
6a9126b
Compare
RobinMalfait
force-pushed
the
fix/source-maps
branch
from
6a9126b
to
9bd7e8b
Compare
This will get rid of special characters that can cause issues / confusion when debugging tests.
…rect source Co-authored-by: Jordan Pittman <jordan@cryptica.me>
RobinMalfait
force-pushed
the
fix/source-maps
branch
from
7ed65e2
to
a4e5838
Compare
RobinMalfait
changed the title
RobinMalfait
changed the title
thecrypticace
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where source maps weren't properly working. This is because we started using Lightning CSS in between our PostCSS plugins.
The implementation of Lightning CSS currently re-parses the CSS therefore losing the original information from the
roottree. After that we reset the result.root based on the result of Lightning CSS.This PR should resolve the source map issues by passing the previous source maps to Lightning CSS, and passing the resulting source maps from Lightning CSS back to PostCSS.