Only sort pseudo elements after classes when using @apply and variants
#9765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamwathan since you were the one who pointed out the less than ideal output what are your thoughts on this fix? |
thecrypticace
force-pushed
the
fix/sort-pseudo-elements-only
branch
from
8278108
to
5413cf5
Compare
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We were previously sorting all pseudos in a selector which meant that
.foo:not(…).bar:not(…)was transformed to.foo.bar:not(…):not(…). While this is still correct it's not optimal for the way@applyworks currently and can result in poor collapsing of adjacent rules (which apply often generates).Fixes #9742 (the original bug was fixed in v3.2.2 — this fixes the not so great output present in v3.2.2)