Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only sort pseudo elements after classes when using @apply and variants #9765

merged 2 commits into from
Nov 9, 2022


Copy link

@thecrypticace thecrypticace commented Nov 7, 2022

We were previously sorting all pseudos in a selector which meant that .foo:not(…).bar:not(…) was transformed to…):not(…). While this is still correct it's not optimal for the way @apply works currently and can result in poor collapsing of adjacent rules (which apply often generates).

Fixes #9742 (the original bug was fixed in v3.2.2 — this fixes the not so great output present in v3.2.2)

Copy link
Contributor Author

@adamwathan since you were the one who pointed out the less than ideal output what are your thoughts on this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Nested SCSS selectors breaking @apply directive
1 participant