Add --watch=always option to prevent exit when stdin closes
#9966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/stdin-closing-option
branch
from
e2f490e
to
057f2d4
Compare
KaelenProctor
added a commit
to KaelenProctor/CubeCobra
that referenced
this pull request
Oct 31, 2024
such as when running in the background in a non-interactive shell (such as in docker). See tailwindlabs/tailwindcss#9966 for details.
KaelenProctor
added a commit
to KaelenProctor/CubeCobra
that referenced
this pull request
Oct 31, 2024
such as when running in the background in a non-interactive shell (such as in docker). See tailwindlabs/tailwindcss#9966 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9870
We were trying our best to not need an option for this but there are too many scenarios where one behavior works for a tool and the other one does not.
In general, exiting when stdin closes is still the only reliable way to guarantee a process actually exits appropriately when orphaned because the OS / kernel itself will close the file handle associated with stdin. But, in certain scenarios, stdin isn't wired up in the first place. For instance: