Skip to content

v1.1 — Multi-day story arc + sprite-frame fix

Choose a tag to compare

@tallPete tallPete released this 10 May 06:04
· 33 commits to main since this release

Two material fixes that changed how Johnny plays.

1. Multi-day story arc — now actually reachable

Sierra's 11-day story arc (raft growing days 3–5, complete by day 6,
Johnny eventually completing the story via VISITOR scenes, cycle wrapping
from 11 back to 1) was effectively un reachable in v1.0:

  • StoryRunner.storyDay reset to 1 on each activation because we didn't
    persist progression across launches.
  • The very first beginNextSequence call advanced to Day 2 because
    advanceDay treated the lastCalendarDay = -1 sentinel as
    "calendar day changed" and bumped immediately.

Both fixed. Story progression now persists in ScreenSaverDefaults and
survives across screensaver activations. Day advancement remains
real-calendar-day driven (one real day = one story day, exactly as in
the original Sierra). Wrap from day 11 back to 1 was already correct.

2. Sprite-frame guard — fixes Z's, fire, walk-behind-the-tree, visitor boat

A category error in Graphics.drawSprite was silently rejecting any
sprite draw where the BMP-slot index exceeded the number of frames in
that bitmap. Three different visible symptoms turned out to be the same
one-character bug:

  • Sleep scene: no Z's curling into the sky
  • Various scenes: missing fire animation frames
  • Walk paths: Johnny didn't appear behind the palm trunk
  • Visitor scenes: missing cargo boat

Fix matches the C reference (jc_reborn) and Go port behaviour: only
validate spriteNo < bitmap.imageCount. The earlier bogus
imageNo < bitmap.imageCount check was conflating two unrelated
quantities.

Tests

  • 103 engine unit tests (was 101 in v1.0; gained 2 sentinel-handling tests)
  • 11 renderer tests
  • All passing.

Install

Download JohnnyScreenSaver-v1.1.zip below, then:

  1. Unzip → JohnnyScreenSaver.saver.
  2. Copy into ~/Library/Screen Savers/.
  3. Strip Gatekeeper's quarantine flag (build is ad-hoc signed):
    xattr -dr com.apple.quarantine ~/Library/Screen\ Savers/JohnnyScreenSaver.saver
  4. Open System Settings → Screen Saver → choose JohnnyScreenSaver →
    Screen Saver Options… → point at your folder of Sierra data files.

See the README
for full instructions and the canonical md5s of the data files.

What's required

This release contains only the Swift engine and renderer. You bring
your own RESOURCE.MAP, RESOURCE.001, and (optional) sound files
from a legitimate copy of the original 1992 Sierra/Dynamix product —
this repository contains no Sierra data and distributes none.

Tested on macOS 26 Tahoe, Apple Silicon.