Stabilize tests for Tarantool 3 features #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
changed the title
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-test-stabilization
branch
from
41b401a to
5dd3ade
Compare
Before this patch, most tests used an assumption that main server is a router. Yet these are two different concepts. `main_server` entity was introduced in Cartridge test helpers Cluster as some server you may refer to for maintenance work, like clusterwide configuration update. Any cluster server is fine to do such operation: router or not. Since most cluster configurations start with router definition, it is often a first server in a list and is chosen to be main_server as well. But no one guarantees that main_server provides router API (both for vshard and crud). Part of #412 Part of #415
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-test-stabilization
branch
from
5dd3ade to
ed48cf4
Compare
Tarantool 3.0 instances start in ro mode. It is possible that masters are not available for write requests right after test case has been started. Cartridge servers run only on Tarantool 1.x and 2.x, so they are expected to work fine without additional changes: Cartridge helpers checks are sophisticated enough. Part of #412 Part of #415
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-test-stabilization
branch
3 times, most recently
from
9e99bd1 to
234560e
Compare
3 tasks
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-test-stabilization
branch
5 times, most recently
from
b5710cf to
fa6e411
Compare
|
Sorry for force-pushes after review requests, should be fine now. |
better0fdead
approved these changes
Mar 27, 2024
| }) | ||
| end) | ||
| end, | ||
| } No newline at end of file |
There was a problem hiding this comment.
add newline at the EOF
Tarantool 3.0 instances start in ro mode. It is possible that masters are not available for write requests right after test case has been started. This patch supports only vshard tests for Tarantool 2.2+. After this patch, schema init is async and we wait for schema to initialize in tests. Part of #412 Part of #415
This patch removes vinyl from test matrices. Since [1], vinyl is considered experimental and we do not guarantee its work with modules. Vinyl clusters like to misbehave in tests, often resulting in failing tests in CI. To improve developer experience, this patch disables them. This patch do not remove vinyl support since there is no vinyl-specific code in crud, but we do not guarantee it anymore. 1. tarantool/doc#3523 Part of #412 Part of #415
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-test-stabilization
branch
from
55bd35d to
b58f9b4
Compare
DifferentialOrange
deleted the
DifferentialOrange/gh-412-test-stabilization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces various test improvements, mostly related to waiting for various async tasks to be completed if a test case expects them to be completed. This improvements are required to properly solve #412 and #415 since, after introducing more async things, flaky tests starts to fail more often. Also previous PRs had ignored the possibility of creating schema on yet ro instance. This PR also covers this issues. This PR does not yet solve #412, so tests still may fail.
I didn't forget about
Part of #412
Part of #415