box: added logic for working with Tarantool schema #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
from
5d1b376 to
b869130
Compare
|
Is this PR ready for review? If so, please assign two reviewers from the team (usually one of them is the repository maintainer, but it is not necessary). |
|
The dot is missed. -> |
oleg-jukovec
requested changes
Jun 20, 2025
It looks a bit ugly for me. For example, I don’t understand why the timestamp might be useful to us. I like the co-authored-by label in the commit message instead: But up to you. |
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
from
b869130 to
fc70848
Compare
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
2 times, most recently
from
afcd25f to
fab4d84
Compare
oleg-jukovec
requested changes
Jun 26, 2025
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
2 times, most recently
from
e7b809e to
84109e1
Compare
oleg-jukovec
approved these changes
Jun 27, 2025
oleg-jukovec
requested review from
patapenka-alexey
and removed request for
dmyger
|
Please, add |
Implemented the `box.Schema()` method that returns a `Schema` object for schema-related operations. Co-authored-by: maksim.konovalov <maksim.konovalov@vk.team> Closes #TNTP-3331
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
from
84109e1 to
e71639f
Compare
patapenka-alexey
approved these changes
Jun 27, 2025
|
Thanks for doing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
box.Schema()method that returns aSchemaobject for schema-related operations.Co-authored-by: maksim.konovalov maksim.konovalov@vk.team