Validate indexes of queue space in driver.new() method #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for all queue drivers new method() now checks that indexes, whihc are crate by create_space() method really exist
kostja
approved these changes
Feb 3, 2020
LeonidVas
reviewed
Feb 17, 2020
| end | ||
|
|
||
| -- validate space of queue | ||
| local function validate_space(space) |
There was a problem hiding this comment.
I agree, WET practice can be used here.
But I suggest using something like:
local function validate_space(space, indexes)
local indexes = {'task_id', 'status'}
for _, index in pairs(indexes) do
if space.index[index] == nil then
error('space does not have ' .. index .. ' index')
end
end
Totktonada
reviewed
Feb 28, 2020
| test:test('task_id index does not exist', function(test) | ||
| test:plan(2) | ||
|
|
||
| space.index.task_id = nil |
There was a problem hiding this comment.
This is not proper use of the index lua api and it is not guaranteed to work in a future. OTOH, I don't see anything that would block usage of <index_object>:drop() and then re-creation of the space for a next test.
|
@olmiik I want to kindly remind you about this PR. There are a couple of small comments. It would be good to resolve them and finally fix the problem for users. |
|
Continued in PR #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for all queue implementations
driver.new()does not validate queue space, created bydriver.create_space()method. However corrupted space can lead to unexpected behavior (for example, see #134),This one adds check to ensure, that indexes, created by
driver.create_space(), really exist.