Add validation ot the space indexes #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonidVas
force-pushed
the
picodata/validate-space
branch
2 times, most recently
from
2d9a9d3 to
ec72049
Compare
For all queue drivers, the "new" method now checks for the presence of indexes created by the "create_space" method. Co-authored-by: Leonid Vasiliev<lvasiliev@tarantool.org> Part of #62
LeonidVas
force-pushed
the
picodata/validate-space
branch
2 times, most recently
from
594a48b to
31135cb
Compare
Totktonada
reviewed
Oct 23, 2020
Totktonada
approved these changes
Oct 23, 2020
Totktonada
reviewed
Oct 23, 2020
If a space is creating with the "if_not_exist = true" option and a space with such name already exists (and this is not a tube of the required type), a conflict will be detected and an error will be thrown. This is necessary because we don't want to create additional indexes for the existing space and repurpose it into the "tube". Closes #62
LeonidVas
force-pushed
the
picodata/validate-space
branch
from
31135cb to
e21bb15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
@ChangeLog Added space schema validation to all core drivers when creating a tube object. If a space is creating with the "if_not_exist = true" option and a space with such name already exists (and this is not a tube of the required type), a conflict will be detected and an error will be thrown.