error: use int64_t as reference counter #5018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I send the PR to mailing list? |
|
I will take a look here. |
Typo: 'increment' -> 'increments'. Also in the commit message we describe the old behaviour using past tense. You said "any of them now can throw", but you should say "any of them could throw". |
Gerold103
requested changes
Jun 2, 2020
Before it was unsafe to use error.prev, box.error.last(), or any error method that increments error reference counter. Any of them could throw a Lua error in case of INT32_MAX overflow. This patch uses int64_t as error reference counter making it impossible to get counter overflow. Closes tarantool#4902
dmitryikh
force-pushed
the
error_ref_to_int64
branch
from
d25d373 to
c4f0862
Compare
|
Thanks, @Gerold103, for review! I fixed the issues. |
Gerold103
approved these changes
Jun 6, 2020
|
You may need a second review, and someone who will merge. @kyukhin probably. |
|
Could you please send your final patch to tarantool-patches mailing list? |
done |
|
It was pushed as 2.5.0-129-g2e3c81dee to @kyukhin I updated drafts of 2.5.1 and 2.4.2 release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was unsafe to use error.prev, box.error.last(), or any error
method that increment error reference counter. Any of them can throw
a Lua error in case of INT32_MAX overflow.
This patch uses int64_t as error reference counter making it impossible
to get counter overflow.
Closes #4902
Unfortunately I don't know how to write tests on this behaviour..