refactor: move payload processor and add wrapper for payload #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
pushed a commit
that referenced
this pull request
Apr 25, 2023
Description --- The PR prevents panic in getting the first output of the `UtxoScannerTask`. Motivation and Context --- The `tari_console_wallet` app fails when a node is syncing: ``` Base Node Status - Chain Tip: #3498 Syncing... Latency 630 ms thread 'tokio-runtime-worker' panicked at 'index out of bounds: the len is 0 but the index is 0', /home/denis/tari/base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs:484:37──────── Network: esmeralda Version: 0.50.0-pre.0 LeftArrow: Previous Tab Tab/RightArrow: Next Tab F10/Ctrl-note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Aborted (core dumped) ``` P.S. I wonder if the `None` value of the `first_output` variable breaks something, and we must panic there. How Has This Been Tested? --- Manually, by starting the `tari_console_wallet` with the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a wrapper to the payload in Hotstuff Messages to allow adding fields in future. For now just added the checkpoint in preparation for committees to vote on it.
Also moved the PayloadProcessor step to prepare. If the payload processor fails because the instructions are not valid at that point, it will not vote to prepare
How Has This Been Tested?
run locally