Merge pull request #23 from sfadschm/test-array-casts

Demonstrate failing array casts.

Author: MGatner

src/Entities/Setting.php

@@ -18,6 +18,21 @@ class Setting extends Entity
 		'protected' => 'bool',
 	];
 
+	/**
+	 * Sets the cast datatype for
+	 * the content field.
+	 *
+	 * @param string $datatype
+	 *
+	 * @return $this
+	 */
+	public function setContentCast(string $datatype = 'string')
+	{
+		$this->casts['content'] = $datatype;
+
+		return $this;
+	}
+
 	/**
 	 * Forces the content to cast
 	 * to its predefined datatype.
@@ -26,7 +41,7 @@ class Setting extends Entity
 	 */
 	public function __construct(array $data = null)
 	{
-		$this->casts['content'] = $data['datatype'] ?? 'string';
+		$this->setContentCast($data['datatype'] ?? 'string');
 
 		parent::__construct($data);
 	}

src/Models/SettingModel.php

@@ -96,7 +96,7 @@ public function getTemplates(): array
 		self::$templates = [];
 		foreach ($templates as $template)
 		{
-			self::$templates[$template['name']] = new Setting($template);
+			self::$templates[$template['name']] = (new Setting())->setContentCast($template['datatype'])->setAttributes($template);
 		}
 
 		return self::$templates;

tests/EntityTest.php

@@ -23,6 +23,24 @@ public function testContentCastsToDatatype()
 		$this->assertSame(12, $setting->content);
 	}
 
+	public function testContentJsonCastsToDatatype()
+	{
+		$array = [
+			'a' => 'Bananas',
+			'b' => 'Oranges',
+		];
+
+		$setting = new Setting([
+			'datatype' => 'json-array',
+			'content'  => $array,
+		]);
+
+		$check = $this->getPrivateProperty($setting, 'attributes')['content'];
+		$this->assertSame('{"a":"Bananas","b":"Oranges"}', $check);
+
+		$this->assertSame($array, $setting->content);
+	}
+
 	public function testFaked()
 	{
 		$setting = fake(SettingModel::class, null, false);

tests/ModelTest.php

@@ -0,0 +1,39 @@
+<?php
+
+use Tatter\Settings\Entities\Setting;
+use Tatter\Settings\Models\SettingModel;
+use Tests\Support\SettingsTestCase;
+
+final class ModelTest extends SettingsTestCase
+{
+	public function testGetTemplatesDoesNotCastDatabaseValues()
+	{
+		// Insert using the model (e.g., admin dashboard)
+		model(SettingModel::class)->insert([
+			'name'      => 'fruits',
+			'datatype'  => 'json-array',
+			'summary'   => 'Yummy fruits',
+			'content'   => '{"a":"Bananas","b":"Oranges"}',
+			'protected' => 1,
+		]);
+
+		// Load templates from the database into the model
+		$model = model(SettingModel::class);
+		$model->getTemplates();
+
+		// The attibute of the entity should be encoded
+		$setting   = $this->getPrivateProperty($model, 'templates')['fruits'];
+		$attribute = $this->getPrivateProperty($setting, 'attributes')['content'];
+
+		$this->assertSame('{"a":"Bananas","b":"Oranges"}', $attribute);
+
+		// The value returned from the getter should be decoded
+		$array = [
+			'a' => 'Bananas',
+			'b' => 'Oranges',
+		];
+
+		$this->assertSame($array, config('Settings')->fruits);
+	}
+
+}