This repository was archived by the owner on Oct 19, 2021. It is now read-only.
Remove transition hooks on replace/detach #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
makes sense to me, I wonder though if there isn't some way you could register a SINGLE transition event of each type that walked up tree when appropriate to look for callbacks registered? not sure which would be better long run tho, 1 "global handler function" per handler type seems a bit better than per handler. |
|
I get what you're saying. So we always have the transition hooks set and then just have a list of elements to match against. If any match, we do the lookup for the transition hook and return that? |
|
Succeeded by #3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @gnarf can you please review this?